-
Notifications
You must be signed in to change notification settings - Fork 265
fix: resolve flaky tests across platforms and Python versions, appearing on main branch #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
===================================
- Coverage 85% 84% -1%
===================================
Files 39 39
Lines 3212 3212
===================================
- Hits 2721 2702 -19
- Misses 491 510 +19 🚀 New features to boost your workflow:
|
…r macOS compatibility
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses flaky test failures occurring inconsistently across different platforms and Python versions in the CI pipeline. The changes focus on improving test reliability through better async event loop handling, platform-specific timing adjustments, and CI workflow optimization.
- Migrates from
asyncio.get_event_loop().run_until_complete()toasyncio.run()for better cross-platform event loop handling - Adds platform-specific timeout adjustments for macOS to account for slower process spawning
- Increases batch timeout values to accommodate varying platform performance
- Optimizes CI workflow to only cancel in-progress runs for pull requests
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/test_loops.py | Replaces deprecated event loop pattern with asyncio.run() for async method calls in synchronous test functions |
| tests/unit/test_lit_server.py | Increases worker restart wait time from 2 to 5 seconds on macOS with explanatory comment |
| tests/unit/test_batch.py | Increases batch timeout test parameter from 0.1 to 0.5 seconds for improved stability |
| .github/workflows/ci-testing.yml | Makes cancel-in-progress conditional, only applying to pull request events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What does this PR do?
Fixes flaky test failures that were occurring inconsistently across different platforms and Python versions in CI. Currently can be seen in main branch.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃