Refactor quantization.py to use TSP #2522
Open
+66
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejapulagam
requested review from
mruberry,
lantiga and
t-vi
as code owners
for more information, see https://pre-commit.ci
t-vi
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Looks great, thank you @tejapulagam .
I wonder if we can process the additional args a tad more elegantly, other than that it seems great.
thunder/transforms/quantization.py
Outdated
| ) | ||
|
|
||
| # Add new compute inputs to the trace args before processing | ||
| new_computation_trace.args = (*new_computation_trace.args, *new_compute_inputs) |
There was a problem hiding this comment.
I wonder if we can do this before the processing and also add the new bindings.
thunder/transforms/quantization.py
Outdated
| else: | ||
| new_computation_trace.bound_symbols.append(bsym.from_bsym()) | ||
| # Insert the new bindings at the beginning of the trace | ||
| new_computation_trace.bound_symbols = new_bindings + new_computation_trace.bound_symbols |
There was a problem hiding this comment.
I would prefer to keep the order of the bindings aligned with the arg order.
There was a problem hiding this comment.
not sure if this is what you had in mind
for more information, see https://pre-commit.ci
…m/tejapulagam/lightning-thunder into refactor/traceSubstitionProcessor
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors thunder/transforms/quantization.py to build the computation trace using TraceSubstitutionProcessor instead of manual bound-symbol rewriting.
Test test_networks.py::test_quantization is still passing.