Skip to content

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Sep 25, 2025

What does this PR do?

Since we use torch.compile w its default values, it doesn't look necessary to register it as an attribute of ThunderCompiler.

just pass it to `_splitter`

Signed-off-by: Masaki Kozuki <[email protected]>
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar
Anyone from the ThunderFX side who want's to take a look before merging?

@shino16
Copy link
Collaborator

shino16 commented Sep 25, 2025

Thank you for pointing this out, I've been wondering why this exists too. This seems to be left off in #1535

@shino16
Copy link
Collaborator

shino16 commented Sep 29, 2025

Why don't we pass this torch_compile_kwargs to torch.compile for submodules? I think it makes more sense to propagate pytorch options for submodule compilation too.

compiled = torch.compile(fn, backend=backend, **torch_compile_kwargs)

@crcrpar
Copy link
Collaborator Author

crcrpar commented Sep 29, 2025

Why don't we pass this torch_compile_kwargs to torch.compile for submodules? I think it makes more sense to propagate pytorch options for submodule compilation too.

compiled = torch.compile(fn, backend=backend, **torch_compile_kwargs)

I've #2196 and #2198. The PR is a zombie now. Feel free to take it over if you want.

@shino16
Copy link
Collaborator

shino16 commented Sep 29, 2025

Thank you for the reference. If this was an intended design choice, I won't argue against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants