Skip to content

Add float4_e2m1fn_x2 to lcdtype_to_nvdtype_map #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add float4_e2m1fn_x2 to lcdtype_to_nvdtype_map #2532

wants to merge 2 commits into from
+8 −0

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Sep 25, 2025 •
edited by github-actions bot
Loading

What does this PR do?

As per title.

cc @tfogal

@crcrpar crcrpar requested a review from jjsjann123 September 25, 2025 08:08
@crcrpar crcrpar requested a review from mruberry as a code owner September 25, 2025 08:08
@crcrpar
Copy link
Collaborator Author

crcrpar commented Sep 25, 2025

@jjsjann123 from which version the packed fp4 dtype is supported? 0.2.27 would be sufficing?

t-vi
t-vi approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar

@crcrpar crcrpar mentioned this pull request Sep 25, 2025
Draft
@jjsjann123
Copy link
Collaborator

jjsjann123 commented Sep 25, 2025 •
edited
Loading

@jjsjann123 from which version the packed fp4 dtype is supported? 0.2.27 would be sufficing?

Nope. 0.2.27 doesn't have that. (i.e. e798e06 when moving files around (with 0.2.27) doesn't have the type)
Looks like 0.2.28 is safe though. (i.e. ed57b64 has the type when bumping version to 0.2.28)

@crcrpar crcrpar requested a review from KaelanDt as a code owner September 25, 2025 18:28
@crcrpar crcrpar force-pushed the nvfuserex-float4-e2m1fn-x2 branch from c0f7bf3 to 7295301 Compare September 29, 2025 11:41
@crcrpar crcrpar force-pushed the nvfuserex-float4-e2m1fn-x2 branch from bd589f8 to 8b6a38d Compare October 7, 2025 05:48
@crcrpar crcrpar enabled auto-merge (squash) October 7, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@jjsjann123 jjsjann123 Awaiting requested review from jjsjann123

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@KaelanDt KaelanDt Awaiting requested review from KaelanDt KaelanDt is a code owner

Assignees
No one assigned
Labels
nvfuser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crcrpar @jjsjann123 @t-vi