avoid torch.float4_e2m1fn_x2 in _get_min_and_val
#2533
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
added
the
thunderfx
|
CI says we need to make the addition conditional on such a dtype existing in PyTorch (would be my favourite) or bump the PT requirement. |
crcrpar
changed the title
torch.float4_e2m1fn_x2 in _get_min_and_valtorch.float4_e2m1fn_x2 in _get_min_and_val
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
crcrpar
force-pushed
the
avoid-fp4-in-sample_stat_calc
branch
from
5c5a438 to
3dfe923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title. We might want to upcast packed fp4 tensors to 16/32-bit to get min and max but for now just avoiding errors from thunderfx
_splitter