Skip to content

Enable interpolate tests, add PrimID mapping for ceil and floor #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −14
Open

Enable interpolate tests, add PrimID mapping for ceil and floor #2609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions thunder/core/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2574,6 +2574,8 @@ def uniform_backward(primal, minval, maxval, g):
prims.PrimIDs.BITWISE_XOR,
prims.PrimIDs.SIGNBIT,
prims.PrimIDs.FULL,
prims.PrimIDs.FLOOR,
prims.PrimIDs.CEIL,
}


Expand Down
14 changes: 0 additions & 14 deletions thunder/tests/opinfos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9839,20 +9839,6 @@ def interpolate_error_generator(op, device, dtype=torch.float32, **kwargs):
error_input_generator=interpolate_error_generator,
torch_reference=torch.nn.functional.interpolate,
dtypes=(datatypes.floating,),
test_directives=(
# PyTorch does not support CPU Half upsample used in interpolate
DecorateInfo(
pytest.mark.xfail,
"test_core_vs_torch_consistency",
dtypes=(datatypes.float16,),
devicetypes=(devices.DeviceType.CPU,),
),
# This should be fixed now; TODO re-enable and test
DecorateInfo(
pytest.mark.xfail,
"test_vjp_correctness",
),
),
)
nn_ops.append(interpolate_opinfo)

Expand Down
Loading