Fix llama2 benchmarks #2767
Merged
Fix llama2 benchmarks #2767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardofelluga
requested review from
KaelanDt,
lantiga and
mruberry
as code owners
shino16
approved these changes
Nov 25, 2025
Collaborator
shino16
left a comment
shino16
left a comment
There was a problem hiding this comment.
Looks good! I confirmed that pytest thunder/benchmarks/targets.py -k test_llama2_causal_self_attention_7b fails on main and passes on this PR.
Collaborator
Author
|
ping @KaelanDt for stamp 🙏 |
Collaborator
Author
|
Ping @KaelanDt for stamp 🙏 This PR is a small fix but it would really help with benchmarking |
KaelanDt
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Lightning-AI/litgpt#1545 the block_idx positional argument is required
Fixes
TypeError: CausalSelfAttention.__init__() missing 1 required positional argument: 'block_idx'