Handled DTensor placements as positional argument for redistribute #2797
Merged
mattteochen merged 6 commits intomainfrom Jan 19, 2026
Merged
Handled DTensor placements as positional argument for redistribute #2797mattteochen merged 6 commits intomainfrom
placements as positional argument for redistribute #2797mattteochen merged 6 commits intomainfrom
Conversation
mattteochen
requested review from
KaelanDt,
lantiga and
mruberry
as code owners
crcrpar
reviewed
Dec 12, 2025
shino16
reviewed
Dec 12, 2025
kshitij12345
approved these changes
Dec 18, 2025
Collaborator
kshitij12345
left a comment
kshitij12345
left a comment
There was a problem hiding this comment.
LGTM, thanks @mattteochen
Collaborator
Author
|
@KaelanDt for review |
Collaborator
Author
|
Hi @KaelanDt, could you please review this? Thank you. |
KaelanDt
approved these changes
Jan 19, 2026
Collaborator
KaelanDt
left a comment
KaelanDt
left a comment
There was a problem hiding this comment.
thank you @mattteochen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PyTorch DTensor redistribute API can accept
placementsas a positional argument.thunderfxlacked this support, making the node unsupported and causing additional graph breaks.Closes #2794.