Skip to content

Added xfail for expected failures#2805

Merged
KaelanDt merged 5 commits intomainfrom
kaixi/mark-failure-new-torch
Dec 16, 2025
Merged

Added xfail for expected failures#2805
KaelanDt merged 5 commits intomainfrom
kaixi/mark-failure-new-torch

Conversation

@mattteochen
Copy link
Collaborator

@mattteochen mattteochen commented Dec 15, 2025

Due to a recent PyTorch change in autograd_function_apply, this is a temporary workaround for CI when running with nightly torch versions.

This accommodates PRs waiting for a proper fix to address this update.

See #2803

@mattteochen mattteochen marked this pull request as ready for review December 15, 2025 14:17
Copy link
Collaborator

@shino16 shino16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your investigation! It is hacky but seems good for the time being.

@mattteochen
Copy link
Collaborator Author

Hey @KaelanDt could you please review? Thanks.

Copy link
Collaborator

@beverlylytle beverlylytle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mattteochen!
It seems like the internals of autograd_function_apply are changing a lot these days. Once it stabilizes we should remember to remove these xfails and update the tests. Could you make an issue and maybe add a TODO comment linking the issue?

@mattteochen
Copy link
Collaborator Author

Thanks, @mattteochen! It seems like the internals of autograd_function_apply are changing a lot these days. Once it stabilizes we should remember to remove these xfails and update the tests. Could you make an issue and maybe add a TODO comment linking the issue?

Yes, it seems that a lot is going on. I'll add the TODO!

Copy link
Collaborator

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mattteochen and for creating the corresponding issue

@KaelanDt KaelanDt merged commit a0d0335 into main Dec 16, 2025
50 of 51 checks passed
@KaelanDt KaelanDt deleted the kaixi/mark-failure-new-torch branch December 16, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments