Conversation
shino16
left a comment
There was a problem hiding this comment.
Thank you for your investigation! It is hacky but seems good for the time being.
|
Hey @KaelanDt could you please review? Thanks. |
There was a problem hiding this comment.
Thanks, @mattteochen!
It seems like the internals of autograd_function_apply are changing a lot these days. Once it stabilizes we should remember to remove these xfails and update the tests. Could you make an issue and maybe add a TODO comment linking the issue?
Yes, it seems that a lot is going on. I'll add the TODO! |
for more information, see https://pre-commit.ci
KaelanDt
left a comment
There was a problem hiding this comment.
thank you @mattteochen and for creating the corresponding issue
Due to a recent PyTorch change in
autograd_function_apply, this is a temporary workaround for CI when running with nightly torch versions.This accommodates PRs waiting for a proper fix to address this update.
See #2803