Skip to content

Conversation

@MagellaX
Copy link
Contributor

@MagellaX MagellaX commented Jan 8, 2026

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #436.

@gitguardian
Copy link

gitguardian bot commented Jan 8, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5685611 Triggered Generic High Entropy Secret b474a69 tests/streaming/test_resolver.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 80%. Comparing base (3e79da4) to head (444acb6).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #781   +/-   ##
===================================
- Coverage    80%    80%   -0%     
===================================
  Files        52     52           
  Lines      7373   7410   +37     
===================================
+ Hits       5915   5938   +23     
- Misses     1458   1472   +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MagellaX
Copy link
Contributor Author

MagellaX commented Jan 10, 2026

Any thoughts? @tchaton @lantiga @justusschock @bhimrazy

@bhimrazy
Copy link
Collaborator

Any thoughts? @tchaton @lantiga @justusschock @bhimrazy

Thanks for the update! @MagellaX
I think resuming mid-epoch may already be enabled (at least in part) by PR #497, but I need to dig a bit deeper to confirm. I’ll review them together and follow up shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restart training with new data, mid-epoch

2 participants