Skip to content

[FEAT] Add Grouped Topk Routing to LLaMAMoE (Based on DeepseekV3MoE) #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[FEAT] Add Grouped Topk Routing to LLaMAMoE (Based on DeepseekV3MoE) #2134

wants to merge 4 commits into from

Conversation

ysjprojects
Copy link
Collaborator

@ysjprojects ysjprojects changed the title [FEAT] Add Grouped Topk Routing to LLaMAMoE (Based on LLaMAMoE) [FEAT] Add Grouped Topk Routing to LLaMAMoE (Based on DeepseekV3MoE) Sep 13, 2025
KaelanDt
KaelanDt reviewed Sep 13, 2025
View reviewed changes
KaelanDt
KaelanDt reviewed Sep 13, 2025
View reviewed changes
KaelanDt
KaelanDt requested changes Sep 13, 2025
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! just a few nits

@ysjprojects
Copy link
Collaborator Author

Hi @KaelanDt @Borda when can this PR be merged?

@KaelanDt
Copy link
Contributor

Hi @KaelanDt @Borda when can this PR be merged?

sorry @ysjprojects we are having some issues with ci on lightning repos, once it is fixed we will merge this. Thank you!

@ysjprojects
Copy link
Collaborator Author

Hi @KaelanDt @Borda when can this PR be merged?

sorry @ysjprojects we are having some issues with ci on lightning repos, once it is fixed we will merge this. Thank you!

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@KaelanDt KaelanDt KaelanDt approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

@lianakoleva lianakoleva Awaiting requested review from lianakoleva lianakoleva is a code owner

@k223kim k223kim Awaiting requested review from k223kim k223kim is a code owner

@andyland andyland Awaiting requested review from andyland andyland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ysjprojects @KaelanDt @Borda