Skip to content

fix(ci) : Optimize Workflow Triggers for Collaborators vs. External Contributors #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ci) : Optimize Workflow Triggers for Collaborators vs. External Contributors #2162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1493494
fix: update pytester job conditions to optimize PR handling
bhimrazy Nov 19, 2025
5520f23
Apply suggestions
bhimrazy Nov 19, 2025
dc4bb68
Apply suggestions
bhimrazy Nov 19, 2025
ee97259
condition doesn't seem to work properly
bhimrazy Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .github/workflows/cpu-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,14 @@ jobs:
python -c "$modules"

pytester:
# skip PR trigger if secrets are not shared as for all forked PRs
# Route PRs based on contributor type to avoid duplicate runs:
# - Collaborators: use pull_request (tests workflow changes from PR)
# - External forks: use pull_request_target (uses trusted workflow from main)
# - Always run for push to main and workflow_dispatch
if: |
github.event_name != 'pull_request' ||
(
github.event_name == 'pull_request' &&
contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)
)
(github.event_name == 'pull_request' && contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)) ||
(github.event_name == 'pull_request_target' && !contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)) ||
(github.event_name != 'pull_request' && github.event_name != 'pull_request_target')
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -137,11 +138,8 @@ jobs:
runs-on: ubuntu-latest
needs: [pytester, testing-imports]
if: |
github.event_name == 'pull_request_target' ||
(
github.event_name == 'pull_request' &&
contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)
)
(github.event_name == 'pull_request_target' && !contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association)) ||
(github.event_name == 'pull_request' && contains('OWNER,MEMBER,COLLABORATOR', github.event.pull_request.author_association))
steps:
- run: echo "${{ needs.pytester.result }}"
- name: failing...
Expand Down