Skip to content

Commit c18a0ec

Browse files
authored
Remove untested NVIDIA Dali example (#16306)
1 parent 669ecff commit c18a0ec

File tree

8 files changed

+3
-275
lines changed

8 files changed

+3
-275
lines changed

.azure/gpu-tests-pytorch.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ pr:
2626
- "examples/pl_basics/backbone_image_classifier.py"
2727
- "examples/pl_basics/autoencoder.py"
2828
- "examples/pl_fault_tolerant/automatic.py"
29-
- "examples/test_pl_examples.py"
30-
- "examples/pl_integrations/dali_image_classifier.py"
3129
- "requirements/pytorch/**"
3230
- "src/pytorch_lightning/**"
3331
- "tests/tests_pytorch/**"

.github/checkgroup.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ subprojects:
4848
- "examples/pl_basics/backbone_image_classifier.py"
4949
- "examples/pl_basics/autoencoder.py"
5050
- "examples/pl_fault_tolerant/automatic.py"
51-
- "examples/test_pl_examples.py"
52-
- "examples/pl_integrations/dali_image_classifier.py"
5351
- "requirements/pytorch/**"
5452
- "src/pytorch_lightning/**"
5553
- "tests/tests_pytorch/**"

dockers/base-cuda/Dockerfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -119,16 +119,6 @@ RUN \
119119
pip install --no-cache-dir horovod && \
120120
horovodrun --check-build
121121

122-
RUN \
123-
CUDA_VERSION_MAJOR=$(python -c "import torch; print(torch.version.cuda.split('.')[0])") && \
124-
py_ver=$(python -c "print(int('$PYTHON_VERSION'.split('.') >= '3.9'.split('.')))") && \
125-
# install DALI, needed for examples
126-
# todo: waiting for 1.4 - https://github.com/NVIDIA/DALI/issues/3144#issuecomment-877386691
127-
if [ $py_ver -eq "0" ]; then \
128-
pip install --extra-index-url https://developer.download.nvidia.com/compute/redist "nvidia-dali-cuda${CUDA_VERSION_MAJOR}0>1.0" ; \
129-
python -c 'from nvidia.dali.pipeline import Pipeline' ; \
130-
fi
131-
132122
RUN \
133123
# CUDA 10.2 doesn't support ampere architecture (8.0).
134124
if [[ "$CUDA_VERSION" < "11.0" ]]; then export TORCH_CUDA_ARCH_LIST=${TORCH_CUDA_ARCH_LIST//";8.0"/}; echo $TORCH_CUDA_ARCH_LIST; fi && \

examples/README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,6 @@ for advanced use cases.
3838

3939
______________________________________________________________________
4040

41-
## Basic Examples
42-
43-
In this folder, we have 1 simple example:
44-
45-
- [Image Classifier + DALI](pl_integrations/dali_image_classifier.py) (defines the model inside the `LightningModule`).
46-
47-
______________________________________________________________________
48-
4941
## Loop examples
5042

5143
Contains implementations leveraging [loop customization](https://pytorch-lightning.readthedocs.io/en/latest/extensions/loops.html) to enhance the Trainer with new optimization routines.

examples/app_components/python/app.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import os
22
from pathlib import Path
33

4-
import lightning as L
54
from examples.components.python.component_tracer import PLTracerPythonScript
65

6+
import lightning as L
7+
78

89
class RootFlow(L.LightningFlow):
910
def __init__(self):

examples/pl_integrations/dali_image_classifier.py

Lines changed: 0 additions & 206 deletions
This file was deleted.

examples/test_pl_examples.py

Lines changed: 0 additions & 44 deletions
This file was deleted.

src/pytorch_lightning/utilities/imports.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,14 @@
1616
import sys
1717

1818
import torch
19-
from lightning_utilities.core.imports import compare_version, module_available, package_available, RequirementCache
19+
from lightning_utilities.core.imports import compare_version, package_available, RequirementCache
2020

2121
_PYTHON_GREATER_EQUAL_3_8_0 = (sys.version_info.major, sys.version_info.minor) >= (3, 8)
2222
_PYTHON_GREATER_EQUAL_3_10_0 = (sys.version_info.major, sys.version_info.minor) >= (3, 10)
2323
_TORCH_LESSER_EQUAL_1_10_2 = compare_version("torch", operator.le, "1.10.2")
2424
# duplicated from lite because HPU is patching it below
2525
_TORCH_GREATER_EQUAL_1_13 = compare_version("torch", operator.ge, "1.13.0")
2626

27-
_DALI_AVAILABLE = module_available("nvidia.dali")
2827
_HABANA_FRAMEWORK_AVAILABLE = package_available("habana_frameworks")
2928
_HIVEMIND_AVAILABLE = package_available("hivemind")
3029
_KINETO_AVAILABLE = torch.profiler.kineto_available()

0 commit comments

Comments
 (0)