-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add MemoryFormat
callback (channels last)
#17680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hello, all. I'm having trouble running Error: |
@Pedrexus This should get you started:
Also, I left a comment here: #15175 (comment) |
for more information, see https://pre-commit.ci
MemoryFormat
callback (channels last)
from lightning.pytorch.utilities.rank_zero import rank_zero_warn | ||
|
||
|
||
class MemoryFormat(Callback): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pedrexus, just thinking if the name is right, since it rather does ReorderImageDimensions
What does this PR do?
This PR fixes issue #15175 by adding a new feature to the
ChannelsLast
callback. This callback changes the module memory format on setup. This is useful when the user wants to use a different memory format and can lead to a considerable speedup in some cases.Fixes #15175
This PR does not introduce any breaking changes.
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist