Skip to content

Update rich_progress.py #18505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update rich_progress.py #18505

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c26ead
Update rich_progress.py
Tribhuvan0 Sep 8, 2023
ca8ab73
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 8, 2023
8ae0745
Merge branch 'master' into Tribhuvan0-patch-2
Borda Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions src/lightning/pytorch/callbacks/progress/rich_progress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,16 +208,43 @@ class RichProgressBarTheme:

"""

description: Union[str, Style] = "white"
progress_bar: Union[str, Style] = "#6206E0"
progress_bar_finished: Union[str, Style] = "#6206E0"
progress_bar_pulse: Union[str, Style] = "#6206E0"
batch_progress: Union[str, Style] = "white"
time: Union[str, Style] = "grey54"
processing_speed: Union[str, Style] = "grey70"
metrics: Union[str, Style] = "white"
metrics_text_delimiter: str = " "
metrics_format: str = ".3f"
@staticmethod
def detect_color_system() -> str:
console = Console()
return console.color_system
Comment on lines +211 to +214
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we make this a proper function?
Is this the recommended way how users should implement their themes with rich?


color_system = detect_color_system.__func__()

# Default colors for each color system
default_colors = {
"truecolor": {
"progress_bar": "bright_blue",
"time": "bright_cyan",
"processing_speed": "bright_yellow",
},
"256": {
"progress_bar": "color51",
"time": "color45",
"processing_speed": "color227",
},
"default": {
"progress_bar": "blue",
"time": "cyan",
"processing_speed": "yellow",
},
}

# Apply specific colors based on the detected color system
colors = default_colors.get(color_system, default_colors["default"])

description: Union[str, Style] = "default"
progress_bar: Union[str, Style] = colors["progress_bar"]
progress_bar_finished: Union[str, Style] = colors["progress_bar"]
progress_bar_pulse: Union[str, Style] = colors["progress_bar"]
batch_progress: Union[str, Style] = "default"
time: Union[str, Style] = colors["time"]
processing_speed: Union[str, Style] = colors["processing_speed"]
metrics: Union[str, Style] = "default"


class RichProgressBar(ProgressBar):
Expand Down