Skip to content

Conversation

ioangatop
Copy link
Contributor

@ioangatop ioangatop commented Oct 25, 2023

What does this PR do?

Fixes #18861

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18864.org.readthedocs.build/en/18864/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Oct 25, 2023
@ioangatop
Copy link
Contributor Author

ioangatop commented Oct 26, 2023

@awaelchli my first commit was actually a quick fix, which actually only adds code, but I found it (i) a bit odd, not pretty lets say, and (ii) it will write to the remote FS csv file twice, but only in case of columns changes

You can check it out here: 763c1a9

If you like it more, since I won't change any tests or other part of code, we could move forward with this one!

@ioangatop
Copy link
Contributor Author

awaelchli are there any updates for this?

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87%. Comparing base (1fc077b) to head (4e3a7ad).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18864   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         269      269           
  Lines       23656    23663    +7     
=======================================
+ Hits        20633    20641    +8     
+ Misses       3023     3022    -1     

@Borda Borda requested a review from awaelchli December 4, 2023 19:04
@ioangatop ioangatop requested review from lantiga and tchaton as code owners June 4, 2024 11:51
@Borda
Copy link
Contributor

Borda commented Mar 14, 2025

@ioangatop could you please get this PR up-to-date? 🐰

@Borda Borda requested a review from ethanwharris as a code owner April 14, 2025 08:47
@Borda
Copy link
Contributor

Borda commented Sep 2, 2025

@bhimrazy could you pls check the failing tests? 🦩

@bhimrazy
Copy link
Collaborator

bhimrazy commented Sep 2, 2025

@bhimrazy could you pls check the failing tests? 🦩

Sure @Borda

@bhimrazy bhimrazy requested a review from Borda September 4, 2025 10:22
@SkafteNicki SkafteNicki added logger Related to the Loggers logger: csv labels Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric logger: csv logger Related to the Loggers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVLogger fails on remote FS on version 2.1.0
5 participants