-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix CSVLogger
for remote FS
#18864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix CSVLogger
for remote FS
#18864
Conversation
for more information, see https://pre-commit.ci
…github.com/ioangatop/pytorch-lightning into ioannis@18861-CSVLogger-fails-on-remote-fs
for more information, see https://pre-commit.ci
…github.com/ioangatop/pytorch-lightning into ioannis@18861-CSVLogger-fails-on-remote-fs
for more information, see https://pre-commit.ci
@awaelchli my first commit was actually a quick fix, which actually only adds code, but I found it (i) a bit odd, not pretty lets say, and (ii) it will write to the remote FS csv file twice, but only in case of columns changes You can check it out here: 763c1a9 If you like it more, since I won't change any tests or other part of code, we could move forward with this one! |
awaelchli are there any updates for this? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18864 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 269 269
Lines 23656 23663 +7
=======================================
+ Hits 20633 20641 +8
+ Misses 3023 3022 -1 |
@ioangatop could you please get this PR up-to-date? 🐰 |
@bhimrazy could you pls check the failing tests? 🦩 |
…te filesystem support
What does this PR do?
Fixes #18861
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18864.org.readthedocs.build/en/18864/