-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Nicer logging of list of dicts for hyper parameters #19963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current hyper parameter logging flattens a config dictionary. However, when a nested element contains a list of dictionaries, it flattens it to a string. This creates indexed sub-elements. This can be useful for network configs with multiple heads or other similar use cases.
@lantiga @Borda @tchaton @justusschock it would be great if you can take a look at this PR ^^ |
Borda
reviewed
Nov 12, 2024
Borda
approved these changes
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19963 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 267 267
Lines 23355 23358 +3
=======================================
+ Hits 20458 20461 +3
Misses 2897 2897 |
Borda
added a commit
that referenced
this pull request
Mar 18, 2025
* Add support for handling lists of dictionaries in logging * Apply suggestions from code review * Update CHANGELOG.md --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 7900105)
lexierule
pushed a commit
that referenced
this pull request
Mar 18, 2025
* Add support for handling lists of dictionaries in logging * Apply suggestions from code review * Update CHANGELOG.md --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 7900105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, when hyper parameters are logged with log_hyperparams the function calls _flatten_dict to collapse the dict to a single level. However, when the config contains a list of dicts, this gets flattened to a single string. Instead I would propose to log the list as [key/0/item, key/1/item] etc.
Fixes #19957
Before submitting
Only a minor change
This does not require any changes just makes the hyper parameter logging slightly nicer
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--19963.org.readthedocs.build/en/19963/