Skip to content

Update LR step scheduler to use total step to work across epochs #20248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update LR step scheduler to use total step to work across epochs #20248

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c59c27f
Update LR step scheduler to use total step
falckt Sep 5, 2024
fd1883f
Merge branch 'master' into stepwise-lr-scheduler
Borda Sep 30, 2024
df71d49
Merge branch 'master' into stepwise-lr-scheduler
falckt Oct 8, 2024
ed97d73
Merge branch 'master' into stepwise-lr-scheduler
Borda Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lightning/pytorch/loops/training_epoch_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def _update_learning_rates(self, interval: str, update_plateau_schedulers: bool)
if update_plateau_schedulers ^ config.reduce_on_plateau:
continue

current_idx = self.batch_idx if interval == "step" else trainer.current_epoch
current_idx = self.total_batch_idx if interval == "step" else trainer.current_epoch
current_idx += 1 # account for both batch and epoch starts from 0
# Take step if call to update_learning_rates matches the interval key and
# the current step modulo the schedulers frequency is zero
Expand Down
Loading