Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Oct 19, 2024

What does this PR do?

aligning with the recent release of PT 2.5

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20351.org.readthedocs.build/en/20351/

cc @tchaton @Borda @justusschock @awaelchli

@github-actions github-actions bot added ci Continuous Integration fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file dockers labels Oct 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success
pl-cpu (macOS-14, lightning, 3.10, 2.1) success
pl-cpu (macOS-14, lightning, 3.11, 2.2.2) success
pl-cpu (macOS-14, lightning, 3.11, 2.3) success
pl-cpu (macOS-14, lightning, 3.12, 2.4.1) success
pl-cpu (macOS-14, lightning, 3.12, 2.5.1) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) success
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) success
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.11, 2.2.2) success
pl-cpu (windows-2022, lightning, 3.11, 2.3) success
pl-cpu (windows-2022, lightning, 3.12, 2.4.1) success
pl-cpu (windows-2022, lightning, 3.12, 2.5.1) success
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success
pl-cpu (macOS-13, pytorch, 3.10, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/utilities/test_imports.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to .azure/gpu-tests-pytorch.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, tests/tests_pytorch/callbacks/test_early_stopping.py, tests/tests_pytorch/checkpointing/test_model_checkpoint.py, tests/tests_pytorch/core/test_metric_result_integration.py, tests/tests_pytorch/helpers/test_datasets.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_logger.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/utilities/test_imports.py, tests/run_standalone_tests.sh, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to .azure/gpu-benchmarks.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/__init__.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.0) success
build-cuda (3.11, 2.2.2, 12.1.0) success
build-cuda (3.11, 2.3.1, 12.1.0) success
build-cuda (3.11, 2.4.1, 12.1.0) success
build-cuda (3.12, 2.5.1, 12.1.0) success
build-pl (3.10, 2.1, 12.1.0) success
build-pl (3.11, 2.2, 12.1.0) success
build-pl (3.11, 2.3, 12.1.0) success
build-pl (3.11, 2.4, 12.1.0) success
build-pl (3.12, 2.5, 12.1.0) success

These checks are required after the changes to .github/workflows/docker-build.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.9, 2.1, oldest) success
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, lightning, 3.12, 2.4.1) success
fabric-cpu (macOS-14, lightning, 3.12, 2.5.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) success
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) success
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.12, 2.4.1) success
fabric-cpu (windows-2022, lightning, 3.12, 2.5.1) success
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success
fabric-cpu (macOS-13, fabric, 3.10, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, tests/tests_fabric/utilities/test_imports.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to .azure/gpu-tests-fabric.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, src/lightning/fabric/__init__.py, tests/tests_fabric/utilities/test_imports.py, tests/run_standalone_tests.sh.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/typing.txt, src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success
install-pkg (ubuntu-22.04, fabric, 3.11) success
install-pkg (ubuntu-22.04, pytorch, 3.9) success
install-pkg (ubuntu-22.04, pytorch, 3.11) success
install-pkg (ubuntu-22.04, lightning, 3.9) success
install-pkg (ubuntu-22.04, lightning, 3.11) success
install-pkg (ubuntu-22.04, notset, 3.9) success
install-pkg (ubuntu-22.04, notset, 3.11) success
install-pkg (macOS-13, fabric, 3.9) success
install-pkg (macOS-13, fabric, 3.11) success
install-pkg (macOS-13, pytorch, 3.9) success
install-pkg (macOS-13, pytorch, 3.11) success
install-pkg (macOS-13, lightning, 3.9) success
install-pkg (macOS-13, lightning, 3.11) success
install-pkg (macOS-13, notset, 3.9) success
install-pkg (macOS-13, notset, 3.11) success
install-pkg (windows-2022, fabric, 3.9) success
install-pkg (windows-2022, fabric, 3.11) success
install-pkg (windows-2022, pytorch, 3.9) success
install-pkg (windows-2022, pytorch, 3.11) success
install-pkg (windows-2022, lightning, 3.9) success
install-pkg (windows-2022, lightning, 3.11) success
install-pkg (windows-2022, notset, 3.9) success
install-pkg (windows-2022, notset, 3.11) success

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/fabric/test.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/typing.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89%. Comparing base (3627c5b) to head (2c018d7).
Report is 69 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20351   +/-   ##
=======================================
  Coverage      89%      89%           
=======================================
  Files         267      267           
  Lines       23065    23070    +5     
=======================================
+ Hits        20574    20579    +5     
  Misses       2491     2491           

@Borda Borda added the priority: 0 High priority task label Oct 21, 2024
@t-vi
Copy link
Contributor

t-vi commented Nov 6, 2024

Nit: we probably should go to 2.5.1

@Borda Borda changed the title bump: Torch 2.5.0 bump: Torch 2.5 Nov 7, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lantiga lantiga merged commit 61a403a into master Nov 12, 2024
117 of 118 checks passed
@lantiga lantiga deleted the bump/pt-2.5 branch November 12, 2024 14:59
Borda added a commit that referenced this pull request Nov 12, 2024
* bump: Torch `2.5.0`

* push docker

* docker

* 2.5.1 and mypy

* update USE_DISTRIBUTED=0 test

* also for pytorch lightning no distributed

* set USE_LIBUV=0 on windows

* try drop pickle warning

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* disable compiling update_metrics

* bump 2.2.x to bugfix

* disable also log in logger connector (also calls metric)

* more point release bumps

* remove unloved type ignore and print some more on exit

* update checkgroup

* minor versions

* shortened version in build-pl

* pytorch 2.4 is with python 3.11

* 2.1 and 2.3 without patch release

* for 2.4.1: docker with 3.11 test with 3.12

---------

Co-authored-by: Thomas Viehmann <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 61a403a)
lantiga pushed a commit that referenced this pull request Nov 12, 2024
* bump: Torch `2.5.0`

* push docker

* docker

* 2.5.1 and mypy

* update USE_DISTRIBUTED=0 test

* also for pytorch lightning no distributed

* set USE_LIBUV=0 on windows

* try drop pickle warning

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* disable compiling update_metrics

* bump 2.2.x to bugfix

* disable also log in logger connector (also calls metric)

* more point release bumps

* remove unloved type ignore and print some more on exit

* update checkgroup

* minor versions

* shortened version in build-pl

* pytorch 2.4 is with python 3.11

* 2.1 and 2.3 without patch release

* for 2.4.1: docker with 3.11 test with 3.12

---------

Co-authored-by: Thomas Viehmann <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 61a403a)
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
* bump: Torch `2.5.0`

* push docker

* docker

* 2.5.1 and mypy

* update USE_DISTRIBUTED=0 test

* also for pytorch lightning no distributed

* set USE_LIBUV=0 on windows

* try drop pickle warning

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* disable compiling update_metrics

* bump 2.2.x to bugfix

* disable also log in logger connector (also calls metric)

* more point release bumps

* remove unloved type ignore and print some more on exit

* update checkgroup

* minor versions

* shortened version in build-pl

* pytorch 2.4 is with python 3.11

* 2.1 and 2.3 without patch release

* for 2.4.1: docker with 3.11 test with 3.12

---------

Co-authored-by: Thomas Viehmann <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file dockers fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants