Skip to content

Proposal(CLI): after_instantiate_classes hook #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Proposal(CLI): after_instantiate_classes hook #20401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531a826
feat(cli): after_instantiate_classes hook
AlessandroW Nov 6, 2024
0852983
Merge branch 'master' into master
lantiga Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lightning/pytorch/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@ def __init__(
self._add_instantiators()
self.before_instantiate_classes()
self.instantiate_classes()
self.after_instantiate_classes()

if self.subcommand is not None:
self._run_subcommand(self.subcommand)
Expand Down Expand Up @@ -560,6 +561,9 @@ def instantiate_classes(self) -> None:
self._add_configure_optimizers_method_to_model(self.subcommand)
self.trainer = self.instantiate_trainer()

def after_instantiate_classes(self) -> None:
"""Implement to run some code after instantiating the classes."""

def instantiate_trainer(self, **kwargs: Any) -> Trainer:
"""Instantiates the trainer.

Expand Down
Loading