Skip to content

Conversation

durandtibo
Copy link
Contributor

@durandtibo durandtibo commented Nov 8, 2024

What does this PR do?

The link for "Level 24: Add a new accelerator or Strategy" in the expert skills page is not working and returns "404 page not found". This PR updates the filename of the "Level 24: Add a new accelerator or Strategy" file to be consistent, and update the link.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20408.org.readthedocs.build/en/20408/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Nov 8, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lantiga lantiga added the ready PRs ready to be merged label Nov 12, 2024
@mergify mergify bot requested a review from a team November 12, 2024 14:49
@Borda Borda changed the title Fix incorrect link in docs for expert level up docs: fix incorrect link in expert level up Nov 12, 2024
@Borda Borda merged commit b0aa504 into Lightning-AI:master Nov 12, 2024
20 of 21 checks passed
@durandtibo durandtibo deleted the docs/expert-link branch November 20, 2024 08:32
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants