Skip to content

bump all macos-13 to -14 #20415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2024
Merged

bump all macos-13 to -14 #20415

merged 3 commits into from
Nov 13, 2024

Conversation

t-vi
Copy link
Contributor

@t-vi t-vi commented Nov 13, 2024 •
edited by github-actions bot
Loading

faster, maybe less flaky.

📚 Documentation preview 📚: https://pytorch-lightning--20415.org.readthedocs.build/en/20415/

@github-actions github-actions bot added ci Continuous Integration package labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
pl-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.4.1) success ✅
pl-cpu (macOS-14, lightning, 3.12, 2.5.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
pl-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) success ✅
pl-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) success ✅
pl-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
pl-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
pl-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.4.1) success ✅
pl-cpu (windows-2022, lightning, 3.12, 2.5.1) success ✅
pl-cpu (macOS-14, pytorch, 3.9, 2.1) success ✅
pl-cpu (ubuntu-20.04, pytorch, 3.9, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.9, 2.1) success ✅
pl-cpu (macOS-14, pytorch, 3.10, 2.1) success ✅
pl-cpu (ubuntu-22.04, pytorch, 3.10, 2.1) success ✅
pl-cpu (windows-2022, pytorch, 3.10, 2.1) success ✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-14, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (macOS-14, lightning, 3.10, 2.1) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (macOS-14, lightning, 3.11, 2.3) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.4.1) success ✅
fabric-cpu (macOS-14, lightning, 3.12, 2.5.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.4.1) success ✅
fabric-cpu (ubuntu-22.04, lightning, 3.12, 2.5.1) success ✅
fabric-cpu (windows-2022, lightning, 3.9, 2.1, oldest) success ✅
fabric-cpu (windows-2022, lightning, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2.2) success ✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.4.1) success ✅
fabric-cpu (windows-2022, lightning, 3.12, 2.5.1) success ✅
fabric-cpu (macOS-14, fabric, 3.9, 2.1) success ✅
fabric-cpu (ubuntu-20.04, fabric, 3.9, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.9, 2.1) success ✅
fabric-cpu (macOS-14, fabric, 3.10, 2.1) success ✅
fabric-cpu (ubuntu-22.04, fabric, 3.10, 2.1) success ✅
fabric-cpu (windows-2022, fabric, 3.10, 2.1) success ✅

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, fabric, 3.9) success ✅
install-pkg (ubuntu-22.04, fabric, 3.11) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.9) success ✅
install-pkg (ubuntu-22.04, pytorch, 3.11) success ✅
install-pkg (ubuntu-22.04, lightning, 3.9) success ✅
install-pkg (ubuntu-22.04, lightning, 3.11) success ✅
install-pkg (ubuntu-22.04, notset, 3.9) success ✅
install-pkg (ubuntu-22.04, notset, 3.11) success ✅
install-pkg (macOS-14, fabric, 3.9) success ✅
install-pkg (macOS-14, fabric, 3.11) success ✅
install-pkg (macOS-14, pytorch, 3.9) success ✅
install-pkg (macOS-14, pytorch, 3.11) success ✅
install-pkg (macOS-14, lightning, 3.9) success ✅
install-pkg (macOS-14, lightning, 3.11) success ✅
install-pkg (macOS-14, notset, 3.9) success ✅
install-pkg (macOS-14, notset, 3.11) success ✅
install-pkg (windows-2022, fabric, 3.9) success ✅
install-pkg (windows-2022, fabric, 3.11) success ✅
install-pkg (windows-2022, pytorch, 3.9) success ✅
install-pkg (windows-2022, pytorch, 3.11) success ✅
install-pkg (windows-2022, lightning, 3.9) success ✅
install-pkg (windows-2022, lightning, 3.11) success ✅
install-pkg (windows-2022, notset, 3.9) success ✅
install-pkg (windows-2022, notset, 3.11) success ✅

These checks are required after the changes to .github/workflows/ci-pkg-install.yml.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (1f2d7a1) to head (5d0da54).
Report is 64 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #20415    +/-   ##
========================================
- Coverage      87%      86%    -1%     
========================================
  Files         267      267            
  Lines       23202    23203     +1     
========================================
- Hits        20189    20067   -122     
- Misses       3013     3136   +123

@t-vi t-vi merged commit 5756c81 into master Nov 13, 2024
89 checks passed
@t-vi t-vi deleted the tom/macos-14 branch November 13, 2024 14:00
MrWhatZitToYaa pushed a commit to MrWhatZitToYaa/pytorch-lightning that referenced this pull request Nov 20, 2024
@t-vi @MrWhatZitToYaa
bump all macos-13 to -14 (Lightning-AI#20415)
45e1f91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

No one assigned

Labels

ci Continuous Integration package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-vi @Borda