-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add doc for TBPTT #20422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for TBPTT #20422
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! I'd recommend moving this section to an How to guide, see comment.
996612c
to
5c367c5
Compare
a0d29f5
to
610809c
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thank you!
A last request: can you add code that readers can just copy and run, after the explanation example? That is, add a snippet with the same code, but with:
- an actual simple RNN (something like https://github.com/Lightning-AI/pytorch-lightning/blob/master/tests/tests_pytorch/helpers/advanced_models.py#L165)
- the call to Trainer
- the
__name__ == "__main__"
section
This will make it easier for readers to just have a working example in front of them in a second by just copy-pasting.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Almost there :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thank you @chualanagit!
This will need to be added to the main index but I can do it after this is merged |
thank you! |
@lantiga can you explain the doc-make errors, these seem to be blocking the merge. I can't seem to figure out what's cause them to fail. |
hey @chualanagit really sorry for the wait on this we're super close, you got two warnings First warning
just change
to
Second warning
just add
to https://github.com/Lightning-AI/pytorch-lightning/blob/master/docs/source-pytorch/common/index.rst |
@chualanagit if you give me write access to your fork I can make these changes and get them in |
I'll make the change now, one second! |
@lantiga fixed and added you as collaborator as well |
What does this PR do?
Fixes #19985
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20422.org.readthedocs.build/en/20422/