Skip to content

Conversation

chualanagit
Copy link
Contributor

@chualanagit chualanagit commented Nov 15, 2024

What does this PR do?

Fixes #19985

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20422.org.readthedocs.build/en/20422/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Nov 15, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I'd recommend moving this section to an How to guide, see comment.

@lantiga lantiga added the waiting on author Waiting on user action, correction, or update label Nov 18, 2024
@chualanagit chualanagit force-pushed the chualan/add-example-for-TBPTT branch from 996612c to 5c367c5 Compare November 25, 2024 19:12
@chualanagit chualanagit force-pushed the chualan/add-example-for-TBPTT branch from a0d29f5 to 610809c Compare November 25, 2024 19:28
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you!

A last request: can you add code that readers can just copy and run, after the explanation example? That is, add a snippet with the same code, but with:

This will make it easier for readers to just have a working example in front of them in a second by just copy-pasting.

Thanks again!

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Almost there :-)

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thank you @chualanagit!

@lantiga
Copy link
Collaborator

lantiga commented Nov 26, 2024

This will need to be added to the main index but I can do it after this is merged

@chualanagit
Copy link
Contributor Author

This will need to be added to the main index but I can do it after this is merged

thank you!

@chualanagit
Copy link
Contributor Author

@lantiga can you explain the doc-make errors, these seem to be blocking the merge. I can't seem to figure out what's cause them to fail.

@lantiga
Copy link
Collaborator

lantiga commented Dec 5, 2024

hey @chualanagit really sorry for the wait on this

we're super close, you got two warnings

First warning

/home/runner/work/pytorch-lightning/pytorch-lightning/docs/source-pytorch/common/tbptt.rst:1: WARNING: Title overline too short.

just change

##############
Truncated Backpropagation Through Time (TBPTT)
##############

to

##############################################
Truncated Backpropagation Through Time (TBPTT)
##############################################

Second warning

/home/runner/work/pytorch-lightning/pytorch-lightning/docs/source-pytorch/common/tbptt.rst: WARNING: document isn't included in any toctree

just add

.. displayitem::
    :header: Truncated Back-Propagation Through Time
    :description: Efficiently step through time when training recurrent models
    :button_link: ../common/tbtt.html
    :col_css: col-md-4
    :height: 180

to https://github.com/Lightning-AI/pytorch-lightning/blob/master/docs/source-pytorch/common/index.rst

@lantiga
Copy link
Collaborator

lantiga commented Dec 9, 2024

@chualanagit if you give me write access to your fork I can make these changes and get them in

@chualanagit
Copy link
Contributor Author

hey @chualanagit really sorry for the wait on this

we're super close, you got two warnings

First warning

/home/runner/work/pytorch-lightning/pytorch-lightning/docs/source-pytorch/common/tbptt.rst:1: WARNING: Title overline too short.

just change

##############
Truncated Backpropagation Through Time (TBPTT)
##############

to

##############################################
Truncated Backpropagation Through Time (TBPTT)
##############################################

Second warning

/home/runner/work/pytorch-lightning/pytorch-lightning/docs/source-pytorch/common/tbptt.rst: WARNING: document isn't included in any toctree

just add

.. displayitem::
    :header: Truncated Back-Propagation Through Time
    :description: Efficiently step through time when training recurrent models
    :button_link: ../common/tbtt.html
    :col_css: col-md-4
    :height: 180

to https://github.com/Lightning-AI/pytorch-lightning/blob/master/docs/source-pytorch/common/index.rst

I'll make the change now, one second!

@chualanagit
Copy link
Contributor Author

@lantiga fixed and added you as collaborator as well

@lantiga lantiga merged commit 1c4612e into Lightning-AI:master Dec 10, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package waiting on author Waiting on user action, correction, or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add truncated backpropagation through time (TBPTT) example

2 participants