Skip to content

improve importing demos #20446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

improve importing demos #20446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe7caf
improve importing demos
Borda Nov 25, 2024
c986bfb
test
Borda Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/lightning/pytorch/demos/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,15 @@
from lightning.pytorch.demos.lstm import LightningLSTM, SequenceSampler, SimpleLSTM # noqa: F401
from lightning.pytorch.demos.transformer import LightningTransformer, Transformer, WikiText2 # noqa: F401
from lightning.pytorch.demos.boring_classes import BoringDataModule, BoringModel, DemoModel
from lightning.pytorch.demos.lstm import LightningLSTM, SequenceSampler, SimpleLSTM
from lightning.pytorch.demos.transformer import LightningTransformer, Transformer, WikiText2

__all__ = [
"LightningLSTM",
"SequenceSampler",
"SimpleLSTM",
"LightningTransformer",
"Transformer",
"WikiText2",
"BoringModel",
"BoringDataModule",
"DemoModel",
]
8 changes: 4 additions & 4 deletions tests/tests_pytorch/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,8 @@ def test_lightning_cli_print_config():
"any.py",
"predict",
"--seed_everything=1234",
"--model=lightning.pytorch.demos.boring_classes.BoringModel",
"--data=lightning.pytorch.demos.boring_classes.BoringDataModule",
"--model=lightning.pytorch.demos.BoringModel",
"--data=lightning.pytorch.demos.BoringDataModule",
"--print_config",
]
out = StringIO()
Expand All @@ -492,8 +492,8 @@ def test_lightning_cli_print_config():

outval = yaml.safe_load(text)
assert outval["seed_everything"] == 1234
assert outval["model"]["class_path"] == "lightning.pytorch.demos.boring_classes.BoringModel"
assert outval["data"]["class_path"] == "lightning.pytorch.demos.boring_classes.BoringDataModule"
assert outval["model"]["class_path"] == "lightning.pytorch.demos.BoringModel"
assert outval["data"]["class_path"] == "lightning.pytorch.demos.BoringDataModule"
assert outval["ckpt_path"] is None


Expand Down
Loading