Make plugin type check more flexible (Fabric) #20452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantiga
requested review from
Borda,
ethanwharris,
justusschock and
tchaton
as code owners
github-actions
bot
added
fabric
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20452 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 267 267
Lines 23274 23276 +2
=======================================
+ Hits 20381 20383 +2
Misses 2893 2893 |
Borda
approved these changes
Nov 26, 2024
tshu-w
pushed a commit
to tshu-w/pytorch-lightning
that referenced
this pull request
Dec 4, 2024
* make plugin type check more flexible * Change signature and make the equivalent changes to Fabric connector --------- Co-authored-by: Jianing Yang <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
lantiga
added a commit
that referenced
this pull request
Dec 10, 2024
* Add `convert_module` to FSDP * Update ChangeLog * make plugin type check more flexible (#20186) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Luca Antiga <[email protected]> * Make plugin type check more flexible (Fabric) (#20452) * make plugin type check more flexible * Change signature and make the equivalent changes to Fabric connector --------- Co-authored-by: Jianing Yang <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> * Pin setuptools for gpu builds * Fix link in doc --------- Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: Jianing Yang <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Luca Antiga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #20186 for Fabric.
Addresses this comment #20186 (comment)
📚 Documentation preview 📚: https://pytorch-lightning--20452.org.readthedocs.build/en/20452/