Skip to content

Fix UnboundLocalError when using the predict method with return_predictions=False. #20484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Fix UnboundLocalError when using the predict method with return_predictions=False. #20484

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76d44a3
any_on_epoch referenced before assignment
farhadrgh Dec 9, 2024
abac98f
Merge pull request #1 from farhadrgh/farhadr/predict
farhadrgh Dec 9, 2024
a905095
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2024
bc20064
Merge branch 'master' into master
farhadrgh Dec 10, 2024
b633228
Merge branch 'master' into master
lantiga Dec 10, 2024
9546a22
Merge branch 'master' into master
lantiga Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/lightning/pytorch/loops/prediction_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,9 @@ def _predict_step(

self.batch_progress.increment_ready()

if not using_dataloader_iter:
any_on_epoch = self._store_data_for_prediction_writer(batch_idx, dataloader_idx)
any_on_epoch = (
self._store_data_for_prediction_writer(batch_idx, dataloader_idx) if not using_dataloader_iter else False
)

# the `_step` methods don't take a batch_idx when `dataloader_iter` is used, but all other hooks still do,
# so we need different kwargs
Expand Down
Loading