Skip to content

fix test compatibility as AdamW became subclass of Adam #20574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix test compatibility as AdamW became subclass of Adam #20574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/tests_pytorch/callbacks/test_lr_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,10 +548,10 @@ def finetune_function(self, pl_module, epoch: int, optimizer):
"""Called when the epoch begins."""
if epoch == 1 and isinstance(optimizer, torch.optim.SGD):
self.unfreeze_and_add_param_group(pl_module.backbone[0], optimizer, lr=0.1)
if epoch == 2 and isinstance(optimizer, torch.optim.Adam):
if epoch == 2 and type(optimizer) is torch.optim.Adam:
self.unfreeze_and_add_param_group(pl_module.layer, optimizer, lr=0.1)

if epoch == 3 and isinstance(optimizer, torch.optim.Adam):
if epoch == 3 and type(optimizer) is torch.optim.Adam:
assert len(optimizer.param_groups) == 2
self.unfreeze_and_add_param_group(pl_module.backbone[1], optimizer, lr=0.1)
assert len(optimizer.param_groups) == 3
Expand Down
Loading