Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lightning/__setup__.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ def _setup_args() -> dict[str, Any]:
"entry_points": {
"console_scripts": [
"fabric = lightning.fabric.cli:_main",
"lightning = lightning.fabric.cli:_legacy_main",
],
},
"setup_requires": [],
Expand Down
6 changes: 6 additions & 0 deletions src/lightning/fabric/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [unreleased] - YYYY-MM-DD

### Removed

Removed legacy supoport for `lightning run model`. Use `fabric run` instead. ([#20588](https://github.com/Lightning-AI/pytorch-lightning/pull/20588))

## [2.5.0] - 2024-12-19

### Added
Expand Down
21 changes: 0 additions & 21 deletions src/lightning/fabric/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
import logging
import os
import re
import subprocess
import sys
from argparse import Namespace
from typing import Any, Optional

Expand Down Expand Up @@ -50,25 +48,6 @@ def _get_supported_strategies() -> list[str]:
if _CLICK_AVAILABLE:
import click

def _legacy_main() -> None:
"""Legacy CLI handler for fabric.

Raises deprecation warning and runs through fabric cli if necessary, else runs the entrypoint directly

"""
hparams = sys.argv[1:]
if len(hparams) >= 2 and hparams[0] == "run" and hparams[1] == "model":
print(
"`lightning run model` is deprecated and will be removed in future versions."
" Please call `fabric run` instead."
)
_main()
return

if _LIGHTNING_SDK_AVAILABLE:
subprocess.run([sys.executable, "-m", "lightning_sdk.cli.entrypoint"] + hparams)
return

@click.group()
def _main() -> None:
pass
Expand Down
Loading