Minor path release 2.5.1 [rebase & merge]
#20589
Conversation
Signed-off-by: withbest <[email protected].> (cherry picked from commit afe5708)
(cherry picked from commit efe311c)
When loading a pytorch-lightning model from MLFlow, I get `TypeError: Type parameter +_R_co without a default follows type parameter with a default`. This happens whenever doing `import pytorch_lightning as pl` which is done by packages like MLFlow. Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Luca Antiga <[email protected]> (cherry picked from commit ee7fa43)
* Fix TBPTT example * Make example self-contained * Update imports * Add test (cherry picked from commit 76f0c54)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 1b26ac4)
(cherry picked from commit 8c2d263)
* test: flaky terminated with signal SIGABRT * str (cherry picked from commit a944e77)
(cherry picked from commit b5eb92a)
* Update twine to 6.0.1 for Python 3.13 * Pin pkginfo * Go with twine 6.0.1 (cherry picked from commit 711abb4)
Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.11.9 to 0.12.0. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.11.9...v0.12.0) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ea59e40)
(cherry picked from commit d902516)
(cherry picked from commit 9afcc58)
Borda
requested review from
ethanwharris,
justusschock,
lantiga,
tchaton and
williamFalcon
as code owners
|
would need also #20509 |
github-actions
bot
added
docs
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/stable #20589 +/- ##
===============================================
- Coverage 88% 87% -0%
===============================================
Files 267 268 +1
Lines 23380 23447 +67
===============================================
+ Hits 20481 20497 +16
- Misses 2899 2950 +51 |
Co-authored-by: Haifeng Jin <[email protected]> (cherry picked from commit 7bd9279)
Co-authored-by: Haifeng Jin <[email protected]> (cherry picked from commit 9ef355b)
…latency significantly. (#20594) * Move save_hparams_to_yaml to log_hparams instead of auto save with metric * Fix params to be optional * Adjust test * Fix test_csv, test_no_name --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 1f5add3)
* Add checkpoint artifact path prefix to MLflow logger Add a new `checkpoint_artifact_path_prefix` parameter to the MLflow logger. * Modify `src/lightning/pytorch/loggers/mlflow.py` to include the new parameter in the `MLFlowLogger` class constructor and use it in the `after_save_checkpoint` method. * Update the documentation in `docs/source-pytorch/visualize/loggers.rst` to include the new `checkpoint_artifact_path_prefix` parameter. * Add a new test in `tests/tests_pytorch/loggers/test_mlflow.py` to verify the functionality of the `checkpoint_artifact_path_prefix` parameter and ensure it is used in the artifact path. * Add CHANGELOG * Fix MLflow logger test for `checkpoint_path_prefix` * Update stale documentation --------- Co-authored-by: Luca Antiga <[email protected]> (cherry picked from commit 87108d8)
* build(deps): bump Lightning-AI/utilities from 0.12.0 to 0.14.0 Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.12.0 to 0.14.0. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.12.0...v0.14.0) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Apply suggestions from code review --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit d15eeff)
Update test_results.py (cherry picked from commit 71793c6)
* Allow a custom parser class when using LightningCLI * Update changelog (cherry picked from commit 5073ac1)
* ci: resolve standalone testing * faster * merge * printenv * here * list * prune * process * printf * stdout * ./ * -e * .coverage * all * rev * notes * notes * notes (cherry picked from commit e8d70bc)
(cherry picked from commit 02e2668)
* bump: testing with future torch 2.6 * bump `typing-extensions` * TORCHINDUCTOR_CACHE_DIR * bitsandbytes * Apply suggestions from code review * _TORCH_LESS_EQUAL_2_6 --------- Co-authored-by: Luca Antiga <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Antiga <[email protected]> (cherry picked from commit a0134d2)
(cherry picked from commit 41315bc)
…#20581) Fix file extension of uploaded model checkpoints Co-authored-by: Seppo Enarvi <[email protected]> (cherry picked from commit 96df8c4)
--------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 40c682e)
* Add support for handling lists of dictionaries in logging * Apply suggestions from code review * Update CHANGELOG.md --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 7900105)
…backs, not just one (#20191) * test: add failing test using two callbacks * fix: save all checkpoint callbacks to wandb * chore: fix mypy * chore: fix ruff --------- Co-authored-by: Christian Gebbe <> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit bd9d114)
* build(deps): bump Lightning-AI/utilities from 0.14.0 to 0.14.1 Bumps [Lightning-AI/utilities](https://github.com/lightning-ai/utilities) from 0.14.0 to 0.14.1. - [Release notes](https://github.com/lightning-ai/utilities/releases) - [Changelog](https://github.com/Lightning-AI/utilities/blob/main/CHANGELOG.md) - [Commits](Lightning-AI/utilities@v0.14.0...v0.14.1) --- updated-dependencies: - dependency-name: Lightning-AI/utilities dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Apply suggestions from code review --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 2011d5a)
* Make error MLFlow deleted experiment explicit --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 29ed24f)
Borda
changed the title
2.5.1 [wip]2.5.1 [rebase & merge]
23 participants
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20589.org.readthedocs.build/en/20589/