Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Mar 18, 2025

What does this PR do?

minor feature update

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20653.org.readthedocs.build/en/20653/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file package labels Mar 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py, requirements/pytorch/docs.txt.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py, src/version.info.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/__init__.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/checkpoint_connector.py, src/lightning/pytorch/trainer/trainer.py, src/lightning/pytorch/utilities/model_registry.py, src/version.info.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 40.44944% with 53 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (29ed24f) to head (0c17cd7).
Report is 119 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (29ed24f) and HEAD (0c17cd7). Click for more details.

HEAD has 321 uploads less than BASE
Flag BASE (29ed24f) HEAD (0c17cd7)
cpu 96 24
python 12 3
lightning_fabric 20 0
pytest 51 0
lightning 61 15
python3.11 24 6
python3.10 24 6
python3.12.7 36 9
gpu 3 0
pytorch2.1 12 6
pytorch_lightning 18 9
pytest-full 48 24
pytorch2.2.2 6 3
pytorch2.3 6 3
pytorch2.5 6 3
pytorch2.4.1 6 3
pytorch2.5.1 6 3
pytorch2.6 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20653     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      265      -2     
  Lines       23364    23394     +30     
=========================================
- Hits        20467    18386   -2081     
- Misses       2897     5008   +2111     

@Borda Borda merged commit 08266a9 into master Mar 18, 2025
81 checks passed
@Borda Borda deleted the add/litmodels branch March 18, 2025 20:10
Borda added a commit that referenced this pull request Mar 18, 2025
lexierule pushed a commit that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docs Documentation related package pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants