Skip to content

fix case-sensitive model name #20661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix case-sensitive model name #20661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/lightning/pytorch/utilities/model_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,24 +63,24 @@ def _parse_registry_model_version(ckpt_path: Optional[_PATH]) -> tuple[str, str]
('model-name', '1.0')
>>> _parse_registry_model_version("registry:model-name")
('model-name', '')
>>> _parse_registry_model_version("registry:version:v2")
>>> _parse_registry_model_version("registry:VERSION:v2")
('', 'v2')

"""
if not ckpt_path or not _is_registry(ckpt_path):
raise ValueError(f"Invalid registry path: {ckpt_path}")

# Split the path by ':'
parts = str(ckpt_path).lower().split(":")
parts = str(ckpt_path).split(":")
# Default values
model_name, version = "", ""

# Extract the model name and version based on the parts
if len(parts) >= 2 and parts[1] != "version":
if len(parts) >= 2 and parts[1].lower() != "version":
model_name = parts[1]
if len(parts) == 3 and parts[1] == "version":
if len(parts) == 3 and parts[1].lower() == "version":
version = parts[2]
elif len(parts) == 4 and parts[2] == "version":
elif len(parts) == 4 and parts[2].lower() == "version":
version = parts[3]

return model_name, version
Expand Down
Loading