Skip to content

Conversation

@allrob23
Copy link
Contributor

@allrob23 allrob23 commented Mar 25, 2025

What does this PR do?

This PR updates available_accelerators to return a set instead of a list, improving performance for membership checks.

Using a set makes membership checks more efficient, reducing time complexity from O(n) to O(1) on average. This change enhances performance while maintaining functionality.

Fixes #20671

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20672.org.readthedocs.build/en/20672/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Mar 25, 2025
@allrob23 allrob23 changed the title perf[registry]: update available_accelerators to return a set Improve performance of available_accelerators by returning a set Mar 25, 2025
@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (df5dee6) to head (7666fd6).
Report is 130 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20672   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         268      268           
  Lines       23449    23449           
=======================================
- Hits        20501    20499    -2     
- Misses       2948     2950    +2     

@Borda Borda merged commit 5cc8471 into Lightning-AI:master Mar 28, 2025
116 checks passed
Borda pushed a commit that referenced this pull request Jun 19, 2025
)

perf[registry]: update available_accelerators to return a set

(cherry picked from commit 5cc8471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve performance of membership checks in registry

2 participants