Skip to content

feat: Add Neptune Scale logger support #20687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

feat: Add Neptune Scale logger support #20687

wants to merge 8 commits into from

Conversation

@SiddhantSadangi
Copy link
Contributor

@SiddhantSadangi SiddhantSadangi commented Mar 31, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Adds support for the new Neptune Scale logger

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20687.org.readthedocs.build/en/20687/

@SiddhantSadangi
Ss/neptune scale integration (#1)
6a0ddf6 
* feat: Added support for Neptune Scale

* chore: update CHANGELOG for Neptune Scale logger support

* chore: Address review comments
@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Mar 31, 2025
@stale
Copy link

stale bot commented Apr 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2025
@stale
Copy link

stale bot commented Apr 27, 2025

This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch.

@stale stale bot closed this Apr 27, 2025
SiddhantSadangi and others added 6 commits May 20, 2025 11:23
@SiddhantSadangi
Merge branch 'Lightning-AI:master' into master
3d01924
@SiddhantSadangi @sourcery-ai
Added checkpointing support to Neptune Scale Logger (#2)
9f4e139 
* feat: Added checkpointing support, updated docs links

* tests: Updated tests

* Apply suggestions from code review

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

* feat: Update NeptuneScaleLogger to log model checkpoint paths instead of uploading checkpoints

* docs: Fix formatting of NeptuneScaleLogger API key and project placeholders in documentation

* Update src/lightning/pytorch/loggers/neptune.py

---------

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@SiddhantSadangi
Merge branch 'Lightning-AI:master' into master
e1d4541
@SiddhantSadangi
Update neptune.py
6a86186
@SiddhantSadangi
Merge branch 'Lightning-AI:master' into master
b4a8c7a
@SiddhantSadangi
Updated docstrings for experiment and run properties. Made `log_c…
86b1d3d 
…onfigs()` more performant
@deependujha
Copy link
Collaborator

hi @SiddhantSadangi , sorry your pr was closed due to no activity. Opening it rn, I'll review it later today.

@deependujha deependujha reopened this Jul 16, 2025
@stale stale bot removed won't fix This will not be worked on labels Jul 16, 2025
@SiddhantSadangi
Copy link
Contributor Author

Hey @deependujha ,
Thanks, but this one can be closed. We are re-architecting the neptune-scale API, and will create a ready-to-review PR once that is done.
Appreciate the proactiveness :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon will be requested when the pull request is marked ready for review williamFalcon is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda will be requested when the pull request is marked ready for review Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file docs Documentation related has conflicts package pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SiddhantSadangi @deependujha