Skip to content

Conversation

updates:
- [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1)
- [github.com/PyCQA/docformatter: 06907d0267368b49b9180eed423fae5697c1e909 → v1.7.5](PyCQA/docformatter@06907d0...v1.7.5)
- [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.11.4](astral-sh/ruff-pre-commit@v0.8.6...v0.11.4)
- [github.com/executablebooks/mdformat: 0.7.21 → 0.7.22](hukkin/mdformat@0.7.21...0.7.22)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py, tests/tests_pytorch/helpers/datasets.py, tests/tests_pytorch/trainer/connectors/test_data_connector.py, tests/tests_pytorch/trainer/logging_/test_logger_connector.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/callbacks/timer.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (02311d0) to head (d47fc12).
Report is 133 commits behind head on master.

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (02311d0) and HEAD (d47fc12). Click for more details.

HEAD has 363 uploads less than BASE
Flag BASE (02311d0) HEAD (d47fc12)
cpu 108 27
python 12 3
lightning_fabric 27 0
pytest 58 0
python3.10 24 6
lightning 61 15
python3.11 24 6
python3.12.7 36 9
python3.12 12 3
gpu 4 0
pytorch2.1 12 6
pytorch_lightning 24 12
pytest-full 54 27
pytorch2.3 6 3
pytorch2.5 6 3
pytorch2.2.2 6 3
pytorch2.4.1 6 3
pytorch2.6 6 3
pytorch2.5.1 6 3
pytorch2.7 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20703     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         268      265      -3     
  Lines       23449    23394     -55     
=========================================
- Hits        20389    18386   -2003     
- Misses       3060     5008   +1948     

@Borda Borda merged commit cd785a4 into master Apr 8, 2025
83 checks passed
@Borda Borda deleted the pre-commit-ci-update-config branch April 8, 2025 10:44
Borda added a commit that referenced this pull request Jun 19, 2025
* [pre-commit.ci] pre-commit suggestions

updates:
- [github.com/codespell-project/codespell: v2.3.0 → v2.4.1](codespell-project/codespell@v2.3.0...v2.4.1)
- [github.com/PyCQA/docformatter: 06907d0267368b49b9180eed423fae5697c1e909 → v1.7.5](PyCQA/docformatter@06907d0...v1.7.5)
- [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.11.4](astral-sh/ruff-pre-commit@v0.8.6...v0.11.4)
- [github.com/executablebooks/mdformat: 0.7.21 → 0.7.22](hukkin/mdformat@0.7.21...0.7.22)
- [github.com/pre-commit/mirrors-prettier: v3.1.0 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v3.1.0...v4.0.0-alpha.8)

* Apply suggestions from code review

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit cd785a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant