Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Apr 16, 2025

What does this PR do?

ubuntu 20.04 was removed from all runners so we need to bump to 22.04

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20719.org.readthedocs.build/en/20719/

@github-actions github-actions bot added docs Documentation related ci Continuous Integration labels Apr 16, 2025
Copy link
Contributor

github-actions bot commented Apr 16, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .github/workflows/code-checks.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86%. Comparing base (03635d2) to head (8b4bbc7).
Report is 137 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #20719    +/-   ##
========================================
- Coverage      87%      86%    -1%     
========================================
  Files         268      268            
  Lines       23449    23449            
========================================
- Hits        20389    20253   -136     
- Misses       3060     3196   +136     

@Borda Borda merged commit d57c2a3 into master Apr 16, 2025
80 checks passed
@Borda Borda deleted the ci/bump-ubuntu branch April 16, 2025 08:54
Borda added a commit that referenced this pull request Apr 25, 2025
(cherry picked from commit d57c2a3)
lexierule pushed a commit that referenced this pull request Apr 25, 2025
(cherry picked from commit d57c2a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants