Skip to content

model update API for checkpointing #20721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

model update API for checkpointing #20721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6f40c
model update API for checkpointing
Borda Apr 16, 2025
510d307
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lightning/pytorch/trainer/connectors/callback_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from datetime import timedelta
from typing import Optional, Union

from lightning_utilities import module_available
from lightning_utilities.core.imports import RequirementCache

import lightning.pytorch as pl
from lightning.fabric.utilities.registry import _load_external_callbacks
Expand Down Expand Up @@ -93,7 +93,7 @@ def _configure_checkpoint_callbacks(self, enable_checkpointing: bool) -> None:
" but found `ModelCheckpoint` in callbacks list."
)
elif enable_checkpointing:
if module_available("litmodels") and self.trainer._model_registry:
if RequirementCache("litmodels >=0.1.7") and self.trainer._model_registry:
trainer_source = inspect.getmodule(self.trainer)
if trainer_source is None or not isinstance(trainer_source.__package__, str):
raise RuntimeError("Unable to determine the source of the trainer.")
Expand All @@ -103,11 +103,11 @@ def _configure_checkpoint_callbacks(self, enable_checkpointing: bool) -> None:
else:
from litmodels.integrations.checkpoints import LightningModelCheckpoint as LitModelCheckpoint

model_checkpoint = LitModelCheckpoint(model_name=self.trainer._model_registry)
model_checkpoint = LitModelCheckpoint(model_registry=self.trainer._model_registry)
else:
rank_zero_info(
"You are using the default ModelCheckpoint callback."
" Install `litmodels` package to use the `LitModelCheckpoint` instead"
" Install `pip install litmodels` package to use the `LitModelCheckpoint` instead"
" for seamless uploading to the Lightning model registry."
)
model_checkpoint = ModelCheckpoint()
Expand Down
Loading