Skip to content

check param is of nn.Parameter type for pruning sanitization #20783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 18, 2025
Merged

check param is of nn.Parameter type for pruning sanitization #20783

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2be5e0b
check param is of nn.Parameter type
chanokin May 3, 2025
f9674f5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 3, 2025
ba5aef4
Update test_pruning.py
rittik9 Jun 15, 2025
8c35cce
Merge pull request #1 from rittik9/patch-3
chanokin Jun 18, 2025
0c783f3
Merge branch 'Lightning-AI:master' into master
chanokin Jun 18, 2025
2ddda83
Update test_pruning.py
rittik9 Jun 18, 2025
db0b6fa
Merge pull request #2 from rittik9/patch-3
chanokin Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lightning/pytorch/callbacks/pruning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,10 @@ def sanitize_parameters_to_prune(

if not parameters_to_prune:
parameters_to_prune = [
(m, p) for p in parameters for m in current_modules if getattr(m, p, None) is not None
(m, p)
for p in parameters
for m in current_modules
if getattr(m, p, None) is not None and isinstance(getattr(m, p, None), nn.Parameter)
]
elif (
isinstance(parameters_to_prune, (list, tuple))
Expand Down