Skip to content

Conversation

@deependujha
Copy link
Collaborator

@deependujha deependujha commented May 12, 2025

What does this PR do?

This PR removes the conditional import logic that checked whether lightning_utilities was >= 0.10 before using rank_zero_only. Since requirements.txt now enforces lightning_utilities>=0.10, the version check is no longer necessary.

Changes:

  • Removed the version check and fallback import for older versions of lightning_utilities.

  • Cleaned up related comments and dead code.

This simplifies the code and avoids maintaining legacy branches that are now unreachable.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20823.org.readthedocs.build/en/20823/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (29f0b13) to head (b9fff94).
⚠️ Report is 142 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20823   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         268      268           
  Lines       23390    23368   -22     
=======================================
- Hits        20335    20330    -5     
+ Misses       3055     3038   -17     

@Borda Borda merged commit dd2912a into Lightning-AI:master May 20, 2025
114 checks passed
@deependujha deependujha deleted the nitpick/remove-redundant-code branch May 20, 2025 07:48
Borda pushed a commit that referenced this pull request Jun 19, 2025
sudiptob2 pushed a commit to sudiptob2/pytorch-lightning that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants