Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented May 19, 2025

What does this PR do?

Error from called workflow Lightning-AI/pytorch-lightning/.github/workflows/_legacy-checkpoints.yml@bef53a86586077c70e8bbd178b341f892c50031d (Line: 116, Col: 13): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.AWS_REGION != ''
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20843.org.readthedocs.build/en/20843/

@github-actions github-actions bot added the ci Continuous Integration label May 19, 2025
Copy link
Contributor

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title ci: debug failing run on master ci: skip failing run on master May 19, 2025
@Borda Borda merged commit 9d93d77 into master May 19, 2025
20 checks passed
@Borda Borda deleted the ci/secrets branch May 19, 2025 12:48
@Borda Borda mentioned this pull request May 19, 2025
7 tasks
Borda added a commit that referenced this pull request Jun 19, 2025
* disabled

(cherry picked from commit 9d93d77)
sudiptob2 pushed a commit to sudiptob2/pytorch-lightning that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants