Skip to content

Fix progress bar display to correctly handle iterable dataset and max_steps during training #20869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025
Merged

Fix progress bar display to correctly handle iterable dataset and max_steps during training #20869

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
087c752
changes to show correct progress bar numbers when using max_steps
bandpooja Jun 1, 2025
b1d45bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 1, 2025
af41d33
adding pytest for correst number of training steps in progress bar
bandpooja Jun 3, 2025
49f7f23
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 3, 2025
e3f86c8
asserting directly on progress bar proprty
bandpooja Jun 10, 2025
4d49e6c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lightning/pytorch/callbacks/progress/progress_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ def total_train_batches(self) -> Union[int, float]:
dataloader is of infinite size.

"""
if self.trainer.max_epochs == -1 and self.trainer.max_steps is not None and self.trainer.max_steps > 0:
remaining_steps = self.trainer.max_steps - self.trainer.global_step
return min(self.trainer.num_training_batches, remaining_steps)
return self.trainer.num_training_batches

@property
Expand Down
Loading