Use lazy string formatting in logging statement in setup.py #20886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAVYANSHTYAGI
requested review from
Borda,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
Borda
approved these changes
Jun 10, 2025
Borda
pushed a commit
that referenced
this pull request
Jun 19, 2025
(cherry picked from commit 3b2a73f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a logging statement in setup.py to use lazy string formatting (logging.info("msg %s", var)) instead of string concatenation. This is in line with best practices for Python logging, as it improves performance and avoids potential formatting issues.
No functional changes to logic.............only improves logging clarity and efficiency.
📚 Documentation preview 📚: https://pytorch-lightning--20886.org.readthedocs.build/en/20886/