Skip to content

Conversation

muthissar
Copy link
Contributor

@muthissar muthissar commented Jun 12, 2025

What does this PR do?

Fixes problem causing LigthningCLI to not support jsonnet config files. Solution, should not change generality.

Fixes #20898

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20899.org.readthedocs.build/en/20899/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 12, 2025
@muthissar
Copy link
Contributor Author

The pull request fails the test due to jsonnet not being installed in the test environment. I am not sure how this should be handled. Is jsonnet supposed to be supported by LightningCLI? In my experience, it is actually supported and therefore jsonnet could simply be added to test dependencies. However, this might open other issues if users experience other problems. I propose:

  1. Removing the test
  2. Add jsonnet to test dependencies

@Borda
Copy link
Collaborator

Borda commented Jun 13, 2025

2. Add jsonnet to test dependencies

lte's add it to https://github.com/Lightning-AI/pytorch-lightning/blob/master/requirements/pytorch/extra.txt

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 13, 2025
@Borda Borda merged commit 76d3d22 into Lightning-AI:master Jun 18, 2025
100 of 101 checks passed
Borda added a commit that referenced this pull request Jun 19, 2025
* Fixing problem for silently supporting jsonnet.
* Included jsonnet as test dependency.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 76d3d22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LightningCLI fails loading jsonnet config files

2 participants