Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 16, 2025

What does this PR do?

Get back green checks on the merged commit to better trace when something broke

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20910.org.readthedocs.build/en/20910/

cc @Borda

@github-actions github-actions bot added the ci Continuous Integration label Jun 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/_templates/theme_variables.jinja, docs/source-fabric/advanced/compile.rst, docs/source-fabric/advanced/multiple_setup.rst, docs/source-fabric/examples/index.rst, docs/source-fabric/fundamentals/convert.rst.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to docs/source-pytorch/_templates/theme_variables.jinja, docs/source-pytorch/advanced/compile.rst, docs/source-pytorch/community/governance.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda marked this pull request as draft June 16, 2025 09:45
@Borda
Copy link
Collaborator Author

Borda commented Jun 16, 2025

need to run all with Lightning-AI/utilities#408

@Borda Borda marked this pull request as ready for review June 16, 2025 10:59
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 16, 2025
@Borda Borda requested a review from williamFalcon as a code owner June 16, 2025 11:23
@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Jun 16, 2025
@github-actions github-actions bot added the data label Jun 16, 2025
@lantiga lantiga merged commit 26e2c2c into master Jun 16, 2025
25 checks passed
@lantiga lantiga deleted the fix/links branch June 16, 2025 12:34
Borda added a commit that referenced this pull request Jun 19, 2025
* fix check for flaky links in readme

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update ci-check-md-links.yml

* force-check-all: "yes"

* fix & skip

* Empty-Commit

* fixing

* fixing

* fixing

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 26e2c2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration data docs Documentation related fabric lightning.fabric.Fabric package pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants