Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Jun 20, 2025

What does this PR do?

Fixes #20609

  • nested lightning modules are not supported but example had nested modules
  • only encoder (nn.Module) is needed for feature extractor anyway
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20923.org.readthedocs.build/en/20923/

@github-actions github-actions bot added docs Documentation related pl Generic label for PyTorch Lightning package labels Jun 20, 2025
@Borda
Copy link
Collaborator

Borda commented Jun 23, 2025

@lantiga mind have look, pls 🙏

@Borda Borda merged commit 95f16c1 into Lightning-AI:master Jul 3, 2025
18 checks passed
@matsumotosan matsumotosan deleted the nested-module-docs branch July 3, 2025 18:33
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit 95f16c1)
Borda pushed a commit that referenced this pull request Aug 13, 2025
(cherry picked from commit 95f16c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested child LightningModules in docs

2 participants