Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 24, 2025

What does this PR do?

it make the controlled decency bumping less effective so we need to gain this control back

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20935.org.readthedocs.build/en/20935/

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .actions/requirements.txt.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to .actions/requirements.txt, .azure/gpu-tests-pytorch.yml.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to .azure/gpu-benchmarks.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .actions/requirements.txt.

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success
build-cuda (3.11, 2.2.2, 12.1.1) success
build-cuda (3.11, 2.3.1, 12.1.1) success
build-cuda (3.11, 2.4.1, 12.1.1) success
build-cuda (3.12, 2.5.1, 12.1.1) success
build-cuda (3.12, 2.6.0, 12.4.1) success
build-pl (3.10, 2.1, 12.1.1) success
build-pl (3.11, 2.2, 12.1.1) success
build-pl (3.11, 2.3, 12.1.1) success
build-pl (3.11, 2.4, 12.1.1) success
build-pl (3.12, 2.5, 12.1.1) success
build-pl (3.12, 2.6, 12.4.1) success
build-pl (3.12, 2.7, 12.6.3, true) success

These checks are required after the changes to .actions/requirements.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .actions/requirements.txt.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to .actions/requirements.txt, .azure/gpu-tests-fabric.yml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .actions/requirements.txt.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to .actions/requirements.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@github-actions github-actions bot added the ci Continuous Integration label Jun 24, 2025
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (6e90049) to head (31e0630).
⚠️ Report is 193 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20935   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         268      268           
  Lines       23453    23453           
=======================================
- Hits        20404    20401    -3     
- Misses       3049     3052    +3     

@justusschock justusschock merged commit e11fae5 into master Jun 24, 2025
132 checks passed
@justusschock justusschock deleted the ci/azure branch June 24, 2025 16:14
Borda added a commit that referenced this pull request Aug 13, 2025
* ci/gpu: drop duplicate/confusing dep. installations

* req?

* jsonargparse <4.27.0

* swap

* jsonargparse >=4.27.0

* -U

(cherry picked from commit e11fae5)
Borda added a commit that referenced this pull request Aug 13, 2025
* ci/gpu: drop duplicate/confusing dep. installations

* req?

* jsonargparse <4.27.0

* swap

* jsonargparse >=4.27.0

* -U

(cherry picked from commit e11fae5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants