-
Notifications
You must be signed in to change notification settings - Fork 3.6k
ci/gpu: drop duplicate/confusing dep. installations #20935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20935 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 268 268
Lines 23453 23453
=======================================
- Hits 20404 20401 -3
- Misses 3049 3052 +3 |
* ci/gpu: drop duplicate/confusing dep. installations * req? * jsonargparse <4.27.0 * swap * jsonargparse >=4.27.0 * -U (cherry picked from commit e11fae5)
* ci/gpu: drop duplicate/confusing dep. installations * req? * jsonargparse <4.27.0 * swap * jsonargparse >=4.27.0 * -U (cherry picked from commit e11fae5)
What does this PR do?
it make the controlled decency bumping less effective so we need to gain this control back
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20935.org.readthedocs.build/en/20935/