Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 25, 2025

What does this PR do?

The exception is not properly surfaced from subprocess so the rerun was never used as a check in logs even though the exception was properly linked, since this sample was correctly rerun:

@pytest.mark.flaky(reruns=3, only_rerun="ProcessExitedException")
def test_rerun():
    from torch.multiprocessing import ProcessExitedException
    raise ProcessExitedException("This is a test exception to trigger a rerun.", 0, 0, 0)
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20940.org.readthedocs.build/en/20940/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jun 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to tests/tests_pytorch/callbacks/test_stochastic_weight_avg.py, tests/tests_pytorch/core/test_results.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to tests/tests_pytorch/callbacks/test_stochastic_weight_avg.py, tests/tests_pytorch/core/test_results.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to tests/tests_fabric/utilities/test_distributed.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) (testing Fabric | latest) success
lightning-fabric (GPUs) (testing Lightning | latest) success

These checks are required after the changes to tests/tests_fabric/utilities/test_distributed.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (242d80f) to head (338f7c7).
⚠️ Report is 190 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20940   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         268      268           
  Lines       23453    23453           
=======================================
- Hits        20404    20401    -3     
- Misses       3049     3052    +3     

@Borda Borda merged commit 04379c2 into master Jun 25, 2025
77 checks passed
@Borda Borda deleted the test/spawn branch June 25, 2025 15:49
Borda added a commit that referenced this pull request Aug 13, 2025
Borda added a commit that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants