update ModelSummary #20945
Open
update ModelSummary #20945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YChienHung
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
for more information, see https://pre-commit.ci
Borda
reviewed
Jun 26, 2025
…lightning into freeze-model-summary
|
@Borda Hi,Borda, is there a problem with my design ? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
Borda
approved these changes
Jul 26, 2025
Borda
reviewed
Aug 8, 2025
| def training_modes(self) -> list[bool]: | ||
| return [layer.training for layer in self._layer_summary.values()] | ||
| def training_modes(self) -> list[int]: | ||
| return [(2 if layer.training else 1) if layer.requires_grad else 0 for layer in self._layer_summary.values()] |
Borda
requested changes
Aug 8, 2025
There was a problem hiding this comment.
Let's first clarify what the desired state is #20944 (comment)
for more information, see https://pre-commit.ci
…lightning into freeze-model-summary
for more information, see https://pre-commit.ci
…lightning into freeze-model-summary
for more information, see https://pre-commit.ci
…lightning into freeze-model-summary
for more information, see https://pre-commit.ci
…lightning into freeze-model-summary
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…lightning into freeze-model-summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20944
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20945.org.readthedocs.build/en/20945/