-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix compatibility for bitsandbytes>=0.46 #20956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wondering how we can validate it since the GPU for some reason installed only |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #20956 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 268 268
Lines 23460 23460
=======================================
Hits 20402 20402
Misses 3058 3058 |
@Borda It looks like there's a docker image being used here with it preinstalled so it already satisfies |
this will push new docker image: https://github.com/Lightning-AI/pytorch-lightning/actions/runs/16019234343 But this line with pytorch-lightning/.azure/gpu-tests-fabric.yml Line 133 in afa7d56
|
all shall be fixed now :) |
* Fix compatibility for bitsandbytes>=0.46 * --upgrade-strategy=eager --------- Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 73f1ab8)
* Fix compatibility for bitsandbytes>=0.46 * --upgrade-strategy=eager --------- Co-authored-by: Jirka B <[email protected]> (cherry picked from commit 73f1ab8)
What does this PR do?
This PR improves compatibility with bitsandbytes.
In bitsandbytes v0.45.0, we introduced
bitsandbytes.functional.int8_vectorwise_quant
andbitsandbytes.functional.int8_double_quant
as replacements forbitsandbytes.functional.double_quant
. At this time we marked the olddouble_quant
function as deprecated, and we then removed it in v0.46.0.Fixes #20926
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20956.org.readthedocs.build/en/20956/