Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Jul 2, 2025

What does this PR do?

as discovered with BnB fixing we sometimes sticked too much with cached packages so automated bumps by @dependabot may not really test the latest versions

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20958.org.readthedocs.build/en/20958/

@github-actions github-actions bot added the ci Continuous Integration label Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to .azure/gpu-tests-pytorch.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86%. Comparing base (73f1ab8) to head (0447c49).
⚠️ Report is 192 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #20958    +/-   ##
========================================
- Coverage      87%      86%    -1%     
========================================
  Files         268      268            
  Lines       23460    23460            
========================================
- Hits        20402    20266   -136     
- Misses       3058     3194   +136     

@justusschock justusschock merged commit 02ddc34 into master Jul 2, 2025
73 checks passed
@justusschock justusschock deleted the ci/upgrade branch July 2, 2025 10:42
Borda added a commit that referenced this pull request Aug 13, 2025
Borda added a commit that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants