Allow training_step in manual optimization to return general mappings
#21011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
justusschock
approved these changes
Jul 31, 2025
tests/tests_pytorch/trainer/optimization/test_manual_optimization.py
Outdated
Show resolved
Hide resolved
bhimrazy
reviewed
Aug 5, 2025
…ion.py Co-authored-by: Bhimraj Yadav <[email protected]>
for more information, see https://pre-commit.ci
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
…gs (#21011) * change dict to mapping * add a bit of testing * changelog * use custom mapping * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update tests/tests_pytorch/trainer/optimization/test_manual_optimization.py Co-authored-by: Bhimraj Yadav <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bhimraj Yadav <[email protected]> Co-authored-by: Deependu Jha <[email protected]> (cherry picked from commit 791753b)
Borda
pushed a commit
that referenced
this pull request
Aug 13, 2025
…gs (#21011) * change dict to mapping * add a bit of testing * changelog * use custom mapping * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update tests/tests_pytorch/trainer/optimization/test_manual_optimization.py Co-authored-by: Bhimraj Yadav <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bhimraj Yadav <[email protected]> Co-authored-by: Deependu Jha <[email protected]> (cherry picked from commit 791753b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20993
Allows users doing manual optimization to return general mappings, including
TensorDictas requested in the issue.This also makes the supported output types consistent between manual and automatic optimization:
pytorch-lightning/src/lightning/pytorch/loops/optimization/automatic.py
Line 65 in d29839b
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21011.org.readthedocs.build/en/21011/